aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Yann E. MORIN <yann.morin.1998@free.fr>2017-08-10 23:51:11 +0200
committerGravatar Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>2017-08-11 12:47:35 +0200
commitafb6bc67a6e3a9fa08a61d81e17e0c152ed09f2a (patch)
treef40be9a505af3c31f00c4594a9d9b5440b6d3972
parente4f7ec4bd1053c3790dc298af39bbdf5e11b5c1d (diff)
downloadbuildroot-afb6bc67a6e3a9fa08a61d81e17e0c152ed09f2a.tar.gz
buildroot-afb6bc67a6e3a9fa08a61d81e17e0c152ed09f2a.tar.bz2
package/valgrind: hide comment when arch is not supported
Currently, the comment that "valgrind needs shared libs" is not hidden when the architecture dependencies are not met, which can confuse some users (as recently seen on IRC). Fix that by introducing the traditional _ARCH_SUPPORTS option, and have the comment and the symbol depend on that. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Brandon Maier <brandon.maier@rockwellcollins.com> Cc: Jérôme Pouiller <jezz@sysmic.org> Cc: Peter Seiderer <ps.report@gmx.net> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com> Reviewed--by: Pedro Ribeiro <pedrib@gmail.com> Tested-by: Pedro Ribeiro <pedrib@gmail.com> [Arnout: put _ARCH_SUPPORTS at the top of the file] Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
-rw-r--r--package/valgrind/Config.in15
1 files changed, 10 insertions, 5 deletions
diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 40e219d95a..75b779d214 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,14 +1,19 @@
+config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
+ bool
+ default y if BR2_ARM_CPU_ARMV7A
+ default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+ default y if BR2_i386 || BR2_x86_64
+ default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
+ depends on !BR2_MIPS_SOFT_FLOAT
+
comment "valgrind needs a toolchain w/ dynamic library"
+ depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
depends on BR2_STATIC_LIBS
config BR2_PACKAGE_VALGRIND
bool "valgrind"
- depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
- BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
- BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
- BR2_x86_64
+ depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
depends on !BR2_STATIC_LIBS
- depends on !BR2_MIPS_SOFT_FLOAT
help
Tool for debugging and profiling Linux programs.