|author||Yann E. MORIN <firstname.lastname@example.org>||2020-02-10 21:51:46 +0100|
|committer||Peter Korsgaard <email@example.com>||2020-02-11 23:39:48 +0100|
package/mesa3d: fix circular dependency in Kconfig
When the r300 driver was introduced in c5ae77c97 (package/mesa3d: add support for gallium r300 driver), a last-minute fix was introduced by Yann, to properly propagate the dependency of a selected symbol. However, this ended up causing a spurious circular dependency that does not really exists, but that Kconfig is not smart enough to detect is in fact OK. Fixing this is pretty non-obvious, but we have an easy way out: the dependency is about libdrm's radeon driver requirement for a toolchain that has the sync4 family of primitives, which is always a given for an x86 toolchain. As the radeon r300 driver is x86-only, this dependency is forcefully fulfilled. So, we drop the propagated dependency, and replace it by a fat comment. Signed-off-by: Yann E. MORIN <firstname.lastname@example.org> Cc: Romain Naour <email@example.com> Cc: Bernd Kuhls <firstname.lastname@example.org> Cc: James Hilliard <email@example.com> Signed-off-by: Peter Korsgaard <firstname.lastname@example.org>
1 files changed, 5 insertions, 1 deletions
diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index ff39652508..dbfc59bad5 100644
@@ -169,7 +169,11 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_PANFROST
bool "Gallium Radeon R300 driver"
depends on BR2_i386 || BR2_x86_64
- depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC # libdrm's radeon
+ # lbdrm's radeon option depends on LIBDRM_HAS_ATOMIC. Propagating
+ # that dependency here causes a circular dependency that Kconfig
+ # can't see is just spurious. However, that dependency is about
+ # the toolchain having sync4 primitives, which is always a given
+ # for x86.