diff options
| author |  Thomas Petazzoni <thomas.petazzoni@bootlin.com> | 2018-11-19 12:19:45 +0100 |
|---|---|---|
| committer |  Peter Korsgaard <peter@korsgaard.com> | 2018-11-26 17:15:49 +0100 |
| commit | 54f7565eb2426ca43ea90a6dd56368d9a96290d9 (patch) | |
| tree | d1900097df71830b6aa7762d7c8fdbb62b76c773 | |
| parent | 3f14fed1ded7a8b5a0bb6f3604f8390a87e4c7f1 (diff) | |
| download | buildroot-54f7565eb2426ca43ea90a6dd56368d9a96290d9.tar.gz buildroot-54f7565eb2426ca43ea90a6dd56368d9a96290d9.tar.bz2 | |
rpm: really take DEPENDENCIES into account
Commit e7af4033c32560594ddbd457b68f6d3713662a26 ("rpm: use the new
gettext logic") introduced a really nasty bug: by adding
$(TARGET_NLS_DEPENDENCIES) to RPM_DEPENDENCIES, it completely
overwrote the existing value of RPM_DEPENDENCIES, entirely masking all
mandatory RPM dependencies.
rpm is fairly towards the end of the alphabet, and most other
mandatory dependencies (berkeleydb, host-pkgconf, file and popt)
appear earlier by alphabetic ordering. Only zlib was afterwards, but
since file depends on zlib, it was always built before. This probably
explains why our autobuilders haven't encountered a single build
failure.
However, a simple "make rpm" clearly exhibits the failure, and
obviously the upcoming per-package folder mechanism makes such bugs
even more obvious.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit 36385f87f38e5efd9d678ce10d59bfe442277eb9)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
| -rw-r--r-- | package/rpm/rpm.mk | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk index 159ae72aa8..87c2059e71 100644 --- a/package/rpm/rpm.mk +++ b/package/rpm/rpm.mk @@ -8,10 +8,10 @@ RPM_VERSION_MAJOR = 4.13 RPM_VERSION = $(RPM_VERSION_MAJOR).0.1 RPM_SOURCE = rpm-$(RPM_VERSION).tar.bz2 RPM_SITE = http://ftp.rpm.org/releases/rpm-$(RPM_VERSION_MAJOR).x -RPM_DEPENDENCIES = host-pkgconf berkeleydb file popt zlib +RPM_DEPENDENCIES = host-pkgconf berkeleydb file popt zlib \ + $(TARGET_NLS_DEPENDENCIES) RPM_LICENSE = GPL-2.0 or LGPL-2.0 (library only) RPM_LICENSE_FILES = COPYING -RPM_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) # 0001-configure-ac-use-link-instead-of-compile-for-gcc-flags-test.patch # 0002-configure-ac-correct-stack-protector-check.patch |